Skip to content

chore: update go to 1.24 #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

chore: update go to 1.24 #1046

merged 2 commits into from
Apr 14, 2025

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Apr 10, 2025

Description

go install github.com/golangci/golangci-lint/cmd/[email protected]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner April 10, 2025 09:24
@darrenvechain darrenvechain mentioned this pull request Apr 10, 2025
10 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (855ae30) to head (ae45678).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   61.73%   60.42%   -1.31%     
==========================================
  Files         219      219              
  Lines       22774    22774              
==========================================
- Hits        14059    13762     -297     
- Misses       7592     7917     +325     
+ Partials     1123     1095      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Worth making an announcement in the channel with the steps to update go and the linter.

Also updating other repos would be great 🙏

@libotony libotony merged commit 3efaf7a into master Apr 14, 2025
19 checks passed
@libotony libotony deleted the darren/chore/go-1.24-master branch April 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants