-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(deps): Update azure (0.25) and azure storage (0.21) #23351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -143,32 +149,31 @@ pub fn build_client( | |||
Some(uri) => ClientBuilder::with_location( | |||
CloudLocation::Custom { | |||
uri: uri.to_string(), | |||
account: account_name.to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to verify, this is different than what was done in #22621
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me.
Look at
- https://vector.dev/docs/reference/configuration/sinks/azure_blob/#storage_account
- https://vector.dev/docs/reference/configuration/sinks/azure_blob/#connection_string
One of these should be set. If not, then we raise an error below.
Datadog ReportBranch report: ❌ 6 Failed (0 Known Flaky), 407 Passed, 0 Skipped, 1m 19.67s Total Time ❌ Failed Tests (6)
|
1720078
to
ffe54be
Compare
Summary
Update azure_core and azure_identity to v0.25 and azure_storage and azure_storage_blobs to v0.21.
This is part of the ongoing effort to update http to 1.x
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Related: #19179
Related: Metaswitch/apt-transport-blob#77
Related: #22917
Related: #23036
Related: #22912
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.