Skip to content

chore(website): Rename base to generated #23353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Conversation

thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Jul 10, 2025

Summary

base is a really bad name for generated files to live under, so this PR renames them. This has been and still is a source of confusion amongst many contributors.

Vector configuration

NA

How did you test this PR?

Delete folders under website named generated/base and then run

make generate-component-docs && cd website && make serve

Verify that the website is properly working

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@thomasqueirozb thomasqueirozb requested review from a team as code owners July 10, 2025 14:41
@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation labels Jul 10, 2025
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 10, 2025
@thomasqueirozb thomasqueirozb enabled auto-merge July 10, 2025 14:46
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jul 10, 2025

Datadog Report

Branch report: cue-base-to-generated
Commit report: 4055d80
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 19.02s Total Time

@pront pront force-pushed the master branch 4 times, most recently from 1720078 to ffe54be Compare July 10, 2025 15:43
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Jul 10, 2025
Merged via the queue into master with commit ca0b951 Jul 10, 2025
74 checks passed
@thomasqueirozb thomasqueirozb deleted the cue-base-to-generated branch July 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants