Adding KeySelectors to get-range #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `get-range` also supports limit and skip now. - bumping the deps to 6.3.23 - adding deps.edn to support git deps - a couple of tweaks to better support raw byte keys
|
Fixes #28. |
vedang
requested changes
Dec 16, 2022
There was a problem hiding this comment.
You are right in that this does complicate the get-range function tremendously.
The code is also a bit difficult to understand, I need to read it again carefully.
I've given a cursory read to the code and made some comments about naming and PR structure. Please make these changes, I will read through this PR and test it in the next week. I will come back with some more comments then.
deps.edn
Outdated
| {:dev | ||
| {:extra-paths ["dev"] | ||
| :extra-deps {org.clojure/clojure {:mvn/version "1.11.1"} | ||
| com.lambdaisland/classpath {:mvn/version "0.0.27"}}} |
There was a problem hiding this comment.
why are "dev" and lambdaisland/classpath needed?
There was a problem hiding this comment.
I removed lambdaisland/classpath. I you want me to remove :dev completely I can also do that, it's just nice for people who might want to use the clojure cli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get-rangealso supports limit and skip now.-
a couple of tweaks to better support raw byte keysSo here the first PR for the issues raised in #29. It essentially adds KeySelectors and
limit/skipoptions toget-range.I am not sure this is is the best approach as this immense overloading of
get-rangemakes the code a bit messy. So maybe worth thinking if a secondget-rangefunction would be a better option.Will follow up with a second PR concerning the ordering returned by get-range.