Fix Clippy Warnings and Update Rust Dependencies for Compatibility #40
+327
−200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on addressing all Rust-side issues flagged by Clippy and compiler warnings, along with essential dependency upgrades to maintain compatibility with the latest stable Rust (1.88+). These changes are required for code health, stability, and long-term maintainability.
Key Changes
Clippy Fixes
Resolved Clippy warnings with
cargo clippy --all-targets --all-features -- -D warningsincluding:Replaced legacy numeric constants:
std::u8::MAX→u8::MAXuse std::u8::MAX;Fixed uninlined format arguments:
Rewrote
format!andprintln!calls using named arguments like:Updated unsafe pointer comparison:
ptr as *const T != endwith!std::ptr::eq(ptr, end)Dependency Upgrades
wasm-bindgen:0.2.84→0.2.100syn:1.0.x→2.0.12rustversion: added (1.0.21) to support newerwasm-bindgenCargo.lockto reflect these changesThese upgrades are required due to breaking changes in recent Rust releases, where older versions of
wasm-bindgenwere incompatible with Rust 1.88+.Code Enhancements
impl Default for Aadhaarfor ergonomic default constructionResult<Sourcecode>were properly corrected:Result<'sc>→Result<Sourcecode<'sc>>How to Test
cargo build --release→ ✅ should build cleanlycargo clippy --all-targets --all-features -- -D warnings→ ✅ zero warningscargo test --allNotes