Added basic descriptions for missing items. #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You've added a bunch of empty columns to the CSV files, which isn't gonna work. |
Author
|
Oops. Used LibreOffice to edit these files. |
magical
reviewed
Mar 30, 2018
Member
magical
left a comment
magical
left a comment
There was a problem hiding this comment.
Looks a lot better, thanks!
Did Gale Wings and Parental Bond change in gen 7, or does the correction apply to gen 6 too?
pokedex/data/csv/item_prose.csv
Outdated
| 142,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 143,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 144,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 145,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." |
Member
There was a problem hiding this comment.
Please change these commas back to semicolons. Using a semicolon here is correct; using a comma would create a comma splice.
pokedex/data/csv/item_prose.csv
Outdated
| 157,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 158,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 159,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." | ||
| 160,9,Used for creating PokéBlocks and Poffins.,"No effect, only useful for planting and cooking." |
Member
There was a problem hiding this comment.
Change commas back to semicolons.
pokedex/data/csv/item_prose.csv
Outdated
| 240,9,Raises the holder's Smartness while in a contest.,Held: Increases the holder's Smartness during a Super Contest's Visual Competition. | ||
| 241,9,Raises the holder's Toughness while in a contest.,Held: Increases the holder's Toughness during a Super Contest's Visual Competition. | ||
| 242,9,Held: Provides a 1/10 (10%) boost in accuracy to the holder.,Held: Increases the accuracy of any move the holder uses by 10% (multiplied; i.e. 70% accuracy is increased to 77%). | ||
| 242,9,Held: Provides a 1/10 (10%) boost in accuracy to the holder.,"Held: Increases the accuracy of any move the holder uses by 10% (multiplied, i.e. 70% accuracy is increased to 77%)." |
Member
There was a problem hiding this comment.
Change comma back to semicolon.
pokedex/data/csv/item_prose.csv
Outdated
| : Ends a wild battle. Cannot be used in trainer battles." | ||
| 619,9,Stores props for the Pokémon Musical.,Stores props for the Pokémon Musical. | ||
| 620,9,Return to the museum in Nacrene City.,Only used as a plot point; this item is given to the player and taken away in the same cutscene. | ||
| 620,9,Return to the museum in Nacrene City.,"Only used as a plot point, this item is given to the player and taken away in the same cutscene." |
pokedex/data/csv/item_prose.csv
Outdated
| 674,9,Doubles the chance of two Pokémon producing an egg at the daycare every 255 steps.,Doubles the chance of two Pokémon producing an egg at the daycare every 255 steps. | ||
| 675,9,Raises the chance of finding a shiny Pokémon.,Raises the chance of finding a shiny Pokémon. | ||
| 676,9,Required to progress in the Plasma Frigate.,Required to progress in the Plasma Frigate. | ||
| 677,9,"Appears in the Café Warehouse on Sunday, return to the customer with a Patrat on Thursday.","Appears in the Café Warehouse on Sunday, return to the customer with a Patrat on Thursday." |
|
|
||
| This effect is passed by []{move:baton-pass}." | ||
| 234,9,Throws held item at the target; power depends on the item.,"Inflicts [regular damage]{mechanic:regular-damage}. Power and type are determined by the user's [held item]{mechanic:held-item}. The item is consumed. If the user is not holding an item, or its item has no set type and power, this move will [fail]{mechanic:fail}. | ||
| 234,9,"Throws held item at the target, power depends on the item.","Inflicts [regular damage]{mechanic:regular-damage}. Power and type are determined by the user's [held item]{mechanic:held-item}. The item is consumed. If the user is not holding an item, or its item has no set type and power, this move will [fail]{mechanic:fail}. |
|
|
||
| This move cannot be selected by []{move:assist} or []{move:metronome}." | ||
| 280,9,Averages Defense and Special Defense with the target.,Averages the user's unmodified [Defense]{mechanic:defense} with the target's unmodified Defense; the value becomes the unmodified Defense for both Pokémon. Unmodified [Special Defense]{mechanic:special-defense} is averaged the same way. | ||
| 280,9,Averages Defense and Special Defense with the target.,"Averages the user's unmodified [Defense]{mechanic:defense} with the target's unmodified Defense, the value becomes the unmodified Defense for both Pokémon. Unmodified [Special Defense]{mechanic:special-defense} is averaged the same way." |
| 283,9,"Inflicts damage based on the target's Defense, not Special Defense.","Inflicts [regular damage]{mechanic:regular-damage}. Damage calculation always uses the target's [Defense]{mechanic:defense}, regardless of this move's damage class." | ||
| 284,9,Inflicts double damage if the target is Poisoned.,"Inflicts [regular damage]{mechanic:regular-damage}. If the target is [poisoned]{mechanic:poisoned}, this move has double power." | ||
| 285,9,Raises the user's Speed by two stages and halves the user's weight.,Raises the user's [Speed]{mechanic:speed} by two [stages]{mechanic:stage}. Halves the user's weight; this effect does not stack. | ||
| 285,9,Raises the user's Speed by two stages and halves the user's weight.,"Raises the user's [Speed]{mechanic:speed} by two [stages]{mechanic:stage}. Halves the user's weight, this effect does not stack." |
Author
|
The change on Gale wings and Parental bond occured in gen VII |
Member
|
We should probably add a changelog entry, then: |
Author
|
There's a lot of changes on abilities and moves. |
Author
|
And some Items changed as well. |
Member
|
Ah, thanks for the link. I only mentioned Parental Bond and Gale Wings because those seem to be the only two abilities updated in the PR. The other changes look good. I'm happy to merge the PR if you add changelog entries for Parental Bond and Gale Wings. You could also revert those two changes and open a new PR for them. (And if you wanted to update some of the other moves and abilities that would be fine too 😁 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing descriptions. They are really basic