Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_orm_execute
event is now used to set the default value for_default_language_id
, since the old method (subclassingQuery._execute_and_instances
) is no longer supported. The old method is still there to maintain compatibility with 1.0-1.3.backref=True
.pokedex/db/tables.py
now has the attributeviewonly=True
: this is required to silence many warnings added in 1.4, and it shouldn't do any harm since as far as I know beside the setup/load/dump functions nothing writes stuff into the database, and those don't really use the ORM to do so. If the SQLAlchemy version is at least 1.3.17 but less than 1.4sync_backref=False
is used as well (since 1.4 it defaults toFalse
).pokedex/db/load.py
there's an intentional cartesian product, addingq = q.filter(true())
is enough to silence the warning.Closes #330