-
-
Notifications
You must be signed in to change notification settings - Fork 826
feat: Bump vega-lite>=6
#3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump vega-lite>=6
#3831
Conversation
|
Thanks! This is great! It seems you deleted some files? Can you double check? |
|
@franzhaas I don't think we can update to
I couldn't tell from your original issue (#3828) if you need the latest I imagine we might also need to update (https://github.com/vega/sphinxext-altair)? From (https://github.com/vega/altair/milestone/11), I think the most relevant issue here would be: I think the plan was that instead of a new |
…ing.py` when called in `generate_schema_wrapper.py` on line `VERSIONS.update_all()`
|
The new added Now we should be able to translate this Vega-lite json example (animated gapminder example) into corresponding Altair syntax...: {
"$schema": "https://vega.github.io/schema/vega-lite/v6.json",
"data": {
"url": "data/gapminder.json"
},
"mark": "point",
"params": [
{
"name": "animation_frame",
"select": {
"type": "point",
"fields": [
"year"
],
"on": "timer"
}
}
],
"transform": [
{
"filter": {
"param": "animation_frame"
}
}
],
"encoding": {
"color": {
"field": "country",
"legend": null
},
"x": {
"field": "fertility",
"type": "quantitative"
},
"y": {
"field": "life_expect",
"type": "quantitative"
},
"time": {
"field": "year",
"type": "ordinal"
}
}
}Agree with @dangotbanned, that we also need a new version of vl-convert for writing the charts to png files to make all tests pass. It is also referenced here: https://github.com/vega/altair/blob/main/tools/versioning.py#L217 (called here: https://github.com/vega/altair/blob/main/tools/generate_schema_wrapper.py#L1402). But for testing locally within a notebook with rendering to html it is already possible. Also agree with @dangotbanned, that restructuring the repository by flattening the structure is indeed a very large task! We should do that separately from this PR. |
|
this should work, but doesn't yet: import altair as alt
from vega_datasets import data
source = data.gapminder.url
animation_frame = alt.selection_point(fields=['year'], on='timer')
chart = alt.Chart(source).mark_point().encode(
x='fertility:Q',
y='life_expect:Q',
color=alt.Color('country:N').legend(None),
time='year:O'
).transform_filter(animation_frame).add_params(animation_frame)Note: It works in editor when run |
|
Got it working in a Jupyter notebook🚀: Screen.Recording.2025-04-25.at.17.34.16.movMaybe caching issues in VSCode |
Great yeah that sounds good @mattijn Only thing I wanted to add is can we do that before an actual
|
|
I think this PR starting on a commit before (#3829) - which is causing the conflicts 🤔 |
|
I'm fine on any of the suggested restructuring, it is just a lot of work that someone has to do🫣 |
…ing.py` when called in `generate_schema_wrapper.py` on line `VERSIONS.update_all()`
2aeb0ca to
3f52e71
Compare
No need to apologize @franzhaas! 🙂 If you're looking to get involved, but not sure where to start - try checking out one of these: |
Should fix this *specfic* failure https://github.com/vega/altair/actions/runs/14695042187/job/41235514359?pr=3831 `vl_convert` is still a blocker
…nto pr/franzhaas/3831
Hey all, just wanted to say that I've started looking into updating vl-convert, but have run into a bunch of roadblocks. I'll try to do some more experimenting soon and write up the challenges if I can't work around them. |
|
ok! vl-convert 1.8.0 adds supports Vega-Lite 6.1 (I didn't add 6.0), and updates Vega to 6.1 as well. So we should be able to push this forward now. Thanks for working on it @franzhaas! |
|
And vl-convert-python 1.8.0 is now on conda-forge as well (that took a bit more work this time around) |
before: application/vnd.vega.v6+json after: application/vnd.vega.v6json
|
@jonmmease, thanks for updating vl-convert! I had to change one test that I like to raise to you. It is in this commit: 9ed9643 Basically before it was: |
|
During docbuild: /home/runner/work/altair/altair/doc/user_guide/generated/channels/altair.Time.rst:32: WARNING: autosummary: failed to import Time.rescale.
Possible hints:
* ModuleNotFoundError: No module named 'altair.Time'
* PycodeError: no source found for module 'builtins'
* KeyError: 'description'
* AttributeError: type object 'Time' has no attribute 'Time'
* ModuleNotFoundError: No module named 'Time'
* KeyError: 'Time'Maybe will be resolved once this is in: vega/vega-lite#9535? |
Thanks @mattijn, that does look odd. Which test was failing? (I don' see that in the commit). |
|
I think it must have been my mistake somehow. Resolved by last commit. |

This PR bumpes vega-lite to the 6.1.0 version