Skip to content

Conversation

@JakeAdler
Copy link
Contributor

This PR will simplify development - the way that this works today is clunky and broken on Windows.

@domoritz
Copy link
Member

Okay. We can use just css. But let's have it in the file so that it's easier to get editor support for css. Also, fix the ci.

@JakeAdler
Copy link
Contributor Author

Okay. We can use just css. But let's have it in the file so that it's easier to get editor support for css. Also, fix the ci.

If you are suggesting that we put the contents of style.ts into a .css file, I don't think it's a good idea because it would mean that we'd have to make changes to our rollup config to allow us to import css or include in the bundle. Let me know if I'm misinterpreting or if you think it's worth making changes to the bundler config.

@domoritz
Copy link
Member

What I'm suggesting is yo have a css file in the sources but then to bundle that css file in a js file in a preprocessing step and include the js file only in the npm bundle. This way people don't need a special bundled config but we get autocomplete etc in our editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants