feat: swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs #9089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alliefeldman
commented
Sep 15, 2023
alliefeldman
commented
- Site examples now use ‘pointer’ events instead of mouse events; all other elements of examples remain unchanged
- Update ‘site/docs/’ to include ‘pointer’ events
- All site examples use ‘pointer’ instead of ‘mouse’ in the instances of -over, -move, -out, -down, -up
- Unit tests include pointer events
- All lint and unit tests pass
|
Can you add feat: to the title? |
alliefeldman
changed the title
|
Done! |
domoritz
requested changes
Sep 19, 2023
…ction, and removed accidental site/ files
domoritz
requested changes
Sep 22, 2023
domoritz
requested changes
Sep 22, 2023
domoritz
requested changes
Oct 4, 2023
| "size": { | ||
| "condition": {"test": {"param": "hover", "empty": false}, "value": 48}, | ||
| "value": 100 | ||
| "mark": "line" |
There was a problem hiding this comment.
Let's leave the indentation as it was before.
domoritz
reviewed
Oct 4, 2023
domoritz
approved these changes
Oct 4, 2023
This was referenced Oct 4, 2023
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…y; update site and docs (vega#9089)
alliefeldman
added a commit
to alliefeldman/vega-lite
that referenced
this pull request
Nov 2, 2023
…y; update site and docs (vega#9089)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.