fix: apply bandPosition to offset channel for grouped bar (so band size works with grouped bars) #9178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| : isRelativeBandSize(bandSize) | ||
| ? (1 - bandSize.band) / 2 | ||
| : 0 | ||
| bandPosition: offsetType === 'encoding' ? 0 : bandPosition |
Contributor
There was a problem hiding this comment.
I tested different combinations of center and offsetType, and found that this is not consistent with the old version.
The bandPosition used by defaultRef is signal-relative value in the old implementation, but 0 in the new implementation, when center is false and offsetType check is true.
This nested ternary expression is already very complex. Consider making it a function and testing it in unit test.
richardliu-db
requested changes
Nov 16, 2023
Contributor
richardliu-db
left a comment
richardliu-db
left a comment
There was a problem hiding this comment.
Left one comment regarding the behavior inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9177
See the fixed example
cc: @richardliu-db