Skip to content

fix: align center for image mark if channel2 not defined #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: align center for image mark if channel2 not defined #9250

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24068a0
reproduce vega script
ChiaLingWeng Feb 2, 2024
7859858
fix: align center for image mark if channel2 not defined
ChiaLingWeng Feb 2, 2024
b996419
Merge branch 'vega:main' into clw/mark_image
ChiaLingWeng Feb 2, 2024
142cb69
style: auto-formatting [CI]
Feb 2, 2024
6a427a7
delete test spec
ChiaLingWeng Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/compile/mark/encode/position-rect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function rectPosition(model: UnitModel, channel: 'x' | 'y' | 'theta' | 'r
const offsetScaleChannel = getOffsetChannel(channel);

const isBarBand = mark === 'bar' && (channel === 'x' ? orient === 'vertical' : orient === 'horizontal');

const isImage = mark === 'image';
// x, x2, and width -- we must specify two of these in all conditions
if (
isFieldDef(channelDef) &&
Expand All @@ -66,7 +66,10 @@ export function rectPosition(model: UnitModel, channel: 'x' | 'y' | 'theta' | 'r
channel,
model
});
} else if (((isFieldOrDatumDef(channelDef) && hasDiscreteDomain(scaleType)) || isBarBand) && !channelDef2) {
} else if (
((isFieldOrDatumDef(channelDef) && hasDiscreteDomain(scaleType)) || isBarBand || isImage) &&
!channelDef2
) {
return positionAndSize(channelDef, channel, model);
} else {
return rangePosition(channel, model, {defaultPos: 'zeroOrMax', defaultPos2: 'zeroOrMin'});
Expand Down