Skip to content

Conversation

@amoghtant-db
Copy link

@amoghtant-db amoghtant-db commented Jul 1, 2024

PR Description

The previous version of Vega-Lite resulted in duplicated axis issues when rendering boxplots with multiple axis. This issue was due to there not being a single, unified Y-axis. Examples can be seen below:
image-20230725-182800 (1)

This PR fixes this issue while passing all unit tests passed by the main branch.

Examples of the feature fix working are seen below:

Experimented with many cases of multi-Y boxplots to verify proper working correctness.

Screenshot 2024-07-01 at 1 38 11 PM Screenshot 2024-07-01 at 1 37 46 PM Screenshot 2024-07-01 at 1 37 13 PM Screenshot 2024-07-01 at 1 36 36 PM

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@amoghtant-db amoghtant-db requested a review from a team as a code owner July 1, 2024 20:48
@amoghtant-db amoghtant-db changed the title [VIZ-4715] Added fix for Vega-Lite duplicated axis issue fix: [VIZ-4715] Added fix for Vega-Lite duplicated axis issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant