Skip to content

fix(compile): Check if groupBy check can be generalized to non-polar coordinates #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: cameron.yick/fix-compile-pie-stack
Choose a base branch
from
Draft

fix(compile): Check if groupBy check can be generalized to non-polar coordinates #9557

wants to merge 4 commits into from

Conversation

@hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Mar 8, 2025 •
edited
Loading

Motivation

Changes

Testing

npx vitest run test/stack.test.ts

Checklist
  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@hydrosquall hydrosquall changed the base branch from main to cameron.yick/fix-compile-pie-stack March 8, 2025 14:14
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from 39fdb52 to 92058b5 Compare March 8, 2025 14:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 8, 2025 •
edited
Loading

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cd9889
Status: ✅  Deploy successful!
Preview URL: https://d1d178f7.vega-lite.pages.dev
Branch Preview URL: https://cameron-yick-test-remove-pol.vega-lite.pages.dev

View logs

@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from e883ba0 to 8b1c3d4 Compare March 8, 2025 14:41
@hydrosquall hydrosquall changed the title Cameron.yick/test remove polar condition fix(compile): Check if stacking condition solution can be generalized to non-polar coordinate systems Mar 8, 2025
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch 10 times, most recently from c8324cd to 2845bb0 Compare March 8, 2025 15:57
@hydrosquall hydrosquall changed the title fix(compile): Check if stacking condition solution can be generalized to non-polar coordinate systems fix(compile): Check if groupBy check can be generalized to non-polar coordinates Mar 8, 2025
@hydrosquall hydrosquall mentioned this pull request Mar 8, 2025
Open
@hydrosquall hydrosquall force-pushed the cameron.yick/fix-compile-pie-stack branch 2 times, most recently from d8b3ab4 to c5eae62 Compare May 1, 2025 13:40
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from 3e59e9e to 1cd9889 Compare May 1, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hydrosquall