-
-
Notifications
You must be signed in to change notification settings - Fork 677
feat(selections): Region/Lasso Selections - v6 #9723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hydrosquall
wants to merge
5
commits into
main
Choose a base branch
from
cameron.yick/redo-vega-lasso-assist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bff340 to
b3a67ab
Compare
1a4f269 to
fed58ed
Compare
Deploying vega-lite with
|
| Latest commit: |
28e0918
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0962b0a0.vega-lite.pages.dev |
| Branch Preview URL: | https://cameron-yick-redo-vega-lasso.vega-lite.pages.dev |
6ff21ee to
32969e6
Compare
872876b to
dfc4370
Compare
d170c9e to
3280083
Compare
This was referenced Nov 24, 2025
Closed
Member
Member
Author
@domoritz thanks for checking! The data URL should be I think the yellow schema warning squiggly appears since the new JSON schema hasn't been published yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Motivation
Changes
Demo:
2025-11-23_17-26-16.mp4
Note
I split the pr by commit so it should be easier to review. The core functional changes are in 1, the tests are in 2.
Changes vs Vega-Lite
Modifications vs original PR
mousetopointerevents for consistency with the interval selectionPotential future work
expectMatchFileSnapshotTesting
snapshot/regionsfolder make senseExpand for code block
{ "$schema": "https://vega.github.io/schema/vega-lite/v6.json", "data": { "url": "https://vega.github.io/editor/data/cars.json" }, "params": [ { "name": "brush", "select": "region" } ], "mark": "point", "encoding": { "x": { "field": "Horsepower", "type": "quantitative" }, "y": { "field": "Miles_per_Gallon", "type": "quantitative" }, "color": { "condition": { "param": "brush", "field": "Cylinders", "type": "ordinal" }, "value": "grey" } } }Notes