Remove colon check in variable names (#494)

* Remove panic for colon in variable name * Rename typo filename * Set random seed for mock --------- Co-authored-by: Vincent Prouillet <[email protected]>
vega · May 23, 2024 · 007bd44 · 007bd44
1 parent 30f91b8
commit 007bd44
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/python/vegafusion/tests/altair_mocks/interactive/scatter_with_layered_histogram/mock.py b/python/vegafusion/tests/altair_mocks/interactive/scatter_with_layered_histogram/mock.py
@@ -2,6 +2,8 @@
 import pandas as pd
 import numpy as np
 
+np.random.seed(1)
+
 # generate fake data
 source = pd.DataFrame({
     'gender': ['M']*1000 + ['F']*1000,

diff --git a/...n/vegafusion/tests/test_conext_manager.py → .../vegafusion/tests/test_context_manager.py b/...n/vegafusion/tests/test_conext_manager.py → .../vegafusion/tests/test_context_manager.py
diff --git a/vegafusion-core/src/variable/mod.rs b/vegafusion-core/src/variable/mod.rs
@@ -4,9 +4,6 @@ use std::hash::{Hash, Hasher};
 
 impl Variable {
     pub fn new(ns: VariableNamespace, name: &str) -> Self {
-        if name.contains(':') {
-            panic!("Variable names may not contain colons")
-        }
         Self {
             namespace: ns as i32,
             name: String::from(name),