Support Vega-Lite 6.1, convert from skypack to jsDelivr #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
changed the title
jonmmease
commented
May 26, 2025
There was a problem hiding this comment.
something's off with text measurement here 🤔
There was a problem hiding this comment.
ah, custom measurement wasn't being registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Vega-Lite 6.1. This version of Vega-Lite is broken in skypack (skypackjs/skypack-cdn#383), so I decided to look into alternatives. It turned out to work well to convert from skypack to the esm module support of jsDelivr, so that's what this PR does.