-
Notifications
You must be signed in to change notification settings - Fork 3
[ 機能追加 ][ title タグ ] カテゴリー、タグ、カスタムタクソノミーのアーカイブに対してタイトルタグ設定機能を追加 #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add VEU_Metabox_Taxonomy_Title class for taxonomy edit forms - Add VEU_Title_Form_Helper class for common form rendering - Update wp-title.php to apply custom taxonomy title tags - Support category, tag, and custom taxonomy title tag settings - Add site title addition option for taxonomy titles - Refactor existing head title metabox to use common helper
bugbot run |
- Add CSRF protection with nonce verification - Fix permission check to use taxonomy-specific capabilities - Remove duplicate hook registration to prevent duplicate form fields
…m/vektor-inc/vk-all-in-one-expansion-unit into feature/wp-title/taxonomy-setting
bugbot run |
bugbot run |
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
Comment @cursor review
or bugbot run
to trigger another review on this PR
kurudrive
approved these changes
Sep 19, 2025
kurudrive
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
#1235
どういう変更をしたか?
カテゴリー、タグ、カスタムタクソノミーのアーカイブページに対してタイトルタグ設定ができるようにしました。
それに伴い、既存の投稿・固定ページ用タイトルタグフォームと共通化するヘルパーを作成しました。
2025-09-18.14.08.59.mov
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
ソースコードについて
デザイン・UI
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
書いていない場合は書かない理由を記載してください。
その他
変更内容について何を確認したか、どういう方法で確認をしたかなど
確認URL
( どこかのデモサイトかテストサーバーにデプロイ済みなどで確認できる場合はそのURL )
レビュワーの確認方法・確認する内容など
実装者と同じ確認を行ってください。
思いつくケース限りのケースでお確かめいただけたら幸いです。
レビュワーに回す前の確認事項
レビュワー向け
確認して変更が反映されていない場合の確認事項