Envio Effects API refactor for RPC calls #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FonsSicca
commented
Sep 29, 2025
There was a problem hiding this comment.
separate folder for effects
FonsSicca
commented
Sep 29, 2025
| }); | ||
|
|
||
| describe("when reward token and liquidity pool exist", () => { | ||
| // TODO: These tests are skipped because they test handlers that now use the Effect API |
There was a problem hiding this comment.
skipped some tests because couldn't really mock the effect api
WooSungD
reviewed
Sep 29, 2025
There was a problem hiding this comment.
surprised by the number of external calls the indexer is making..
There was a problem hiding this comment.
Agreed. I think they can hopefully be cut down, I'm not sure what is necessary vs not.
WooSungD
reviewed
Sep 29, 2025
WooSungD
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #353
Implements: