Refactor CLPool event handling to aggregate-driven architecture with business logic isolation #364
Conversation
…siness logic isolation
| - event: CollectFees(address indexed recipient, uint128 amount0, uint128 amount1) | ||
| - event: Flash(address indexed sender, address indexed recipient, uint256 amount0, uint256 amount1, uint256 paid0, uint256 paid1) | ||
| - event: IncreaseObservationCardinalityNext(uint16 observationCardinalityNextOld, uint16 observationCardinalityNextNew) | ||
| - event: Initialize(uint160 sqrtPriceX96, int24 tick) |
There was a problem hiding this comment.
this event didn't have any useful information afaik
There was a problem hiding this comment.
deleted a bunch of CLPool entities and added some fields on User and pool entities
There was a problem hiding this comment.
changed the approach here
update functions of the user and pool entitities compute the final values: current + diff for cumulative quantities
For other quantities, just substitute current with diff
There was a problem hiding this comment.
hmmm I don't understand, was it previously assigning diff to cumulative values?
There was a problem hiding this comment.
Yes exactly. The previous code simply substituted all values (cumulative and not cumulative) of current by the values of diff.
This is right for non-cumulative variables but it was wrong for cumulative
There was a problem hiding this comment.
okay so this is a bug fix rather than a refactor right?
There was a problem hiding this comment.
centralised user stats updates into a single function
There was a problem hiding this comment.
standardized the logic flow accross all event handlers + deleted event-driven entities that aren't used now
There was a problem hiding this comment.
business logic for CLPoolBurn
There was a problem hiding this comment.
business logic for CLPoolFlash
There was a problem hiding this comment.
refactored this taking into account that event-driven entities no longer exist
There was a problem hiding this comment.
same as above comment
There was a problem hiding this comment.
standardize "diff" definition -> diff should always be only the changes derived from the event
There was a problem hiding this comment.
standardize "diff" definition -> diff should always be only the changes derived from the event
There was a problem hiding this comment.
standardize "diff" definition -> diff should always be only the changes derived from the event
2 participants
Implements:
Removed individual CLPool event entities (
CLPool_Burn,CLPool_Collect,CLPool_CollectFees,CLPool_Flash,CLPool_Mint,CLPool_Swap) and consolidated data into LiquidityPoolAggregator and UserStatsPerPool entitiesBusiness logic isolation: Extracted complex calculations into dedicated logic files (
CLPoolBurnLogic,CLPoolCollectLogic,CLPoolFlashLogic, etc.) with consistent processCLPool* interfaces for improved testability and maintainabilityReplaced specific update functions with generic
updateUserStatsPerPooland enhancedupdateLiquidityPoolAggregatorto properly handle cumulative vs non-cumulative fieldsEnhanced schema for CL pools: Added CL-specific fields (feeProtocol0/1, observationCardinalityNext, totalFlashLoanFees0/1/USD, totalFlashLoanVolumeUSD, numberOfFlashLoans) to pool aggregators and user stats
Refactored all tests with exact assertions, proper mocking, and consistent patterns to ensure reliability of the new architecture
Standardized all CLPool handlers to follow the same data loading → processing → updating flow for improved maintainability