Upgrade to React 18 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarr0n
commented
Feb 12, 2024
| @@ -1,4 +1,5 @@ | |||
| module.exports = { | |||
| preset: 'ts-jest', | |||
| testEnvironment: 'jsdom', | |||
| testRunner: 'jest-jasmine2', | |||
There was a problem hiding this comment.
aarr0n
commented
Feb 12, 2024
| @@ -14,6 +14,8 @@ import * as React from 'react'; | |||
| import { Simulate } from 'react-dom/test-utils'; | |||
| import { reactular } from './reactular'; | |||
|
|
|||
| const wait = () => new Promise(resolve => setTimeout(resolve, 10)); | |||
There was a problem hiding this comment.
This is an alternative to using act which I couldn't use because Jest thinks we're not in a React environment.
edsrzf
approved these changes
Feb 12, 2024
| "react": "^16.9.0 || ^17.0.0", | ||
| "react-dom": "^16.9.0 || ^17.0.0" | ||
| "@types/react": "^18.0.0", | ||
| "react": "^18.0.0", |
There was a problem hiding this comment.
Not a big deal at all, but would these changes be compatible with React 16 or 17? I'm guessing not, but just double-checking.
I'm not sure if anyone else actually uses this package, but it could be nice to allow older versions if it's not a burden.
There was a problem hiding this comment.
The new Root API is React 18 only unfortunately. If we leave things as they are and use render, React will just behave as if its running React 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to React18 and bumping dependencies as well.