fix Language.hu.xml invalid character #1516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balintx Thank you for reporting this issue. Actually the Hungarian XML file content is valid and the presence of '>' character is correct. The issue is on the XML parsing code in the file Main/Xml.cpp file: the method GetNodes implementation doesn't parse multiple attributes correctly. I have implemented a fix for this method and I will be pushing it soon. This means that this PR will not be merged since there is no need modifying the valid Hungarian XML file. I will update here when I push the fix. |
idrassi
added a commit
that referenced
this pull request
Mar 24, 2025
…XML parser. The method GetNodes implementation didn't parse multiple attributes correctly and it failed with Hungarian XML because of the presence of '>' character in an attribute value. Issue reported in #1516
|
I have pushed a fix for the XML parser that was causing the issue: 56301ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the invalid XML in the Hungarian translation XML file, which cause the following error when trying to launch Veracrypt:
ParameterIncorrect at VeraCrypt::XmlParser::GetNodes:82