Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the with-jotai example from page router to app router #63390

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Migrate the with-jotai example from page router to app router #63390

merged 6 commits into from
Mar 18, 2024

Conversation

ariannargesi
Copy link
Contributor

@ariannargesi ariannargesi commented Mar 17, 2024 •
edited
Loading

Migrate the with-jotai example from page router to app router

Please if it needs further updates, Let me know!
Happy to contribute

@ariannargesi ariannargesi requested review from a team as code owners March 17, 2024 21:56
@ariannargesi ariannargesi requested review from ismaelrumzan and StephDietz and removed request for a team March 17, 2024 21:56
@ijjk ijjk added the examples Issue/PR related to examples label Mar 17, 2024
@ijjk
Copy link
Member

ijjk commented Mar 17, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: 642357e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ariannargesi ariannargesi changed the title Migrate the with-jotay example from page router to app router Migrate the with-jotai example from page router to app router Mar 17, 2024
@ariannargesi
Copy link
Contributor Author

Any updates on this one?

@samcx samcx enabled auto-merge (squash) March 18, 2024 20:37
samcx
samcx approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm: @

@samcx
Copy link
Member

samcx commented Mar 18, 2024

@ariannargesi Looks we need to prettier the files correctly :frog-eyes:

@ariannargesi
Copy link
Contributor Author

@samcx
There is no prettier config in the example. How should I config the project in order to be aligned with standards?

@samcx
Copy link
Member

samcx commented Mar 18, 2024

@ariannargesi It's to align with the repositories standards—no prettier config is necessary in the example. You can simple run pnpm prettier --write <relative-path-to-files-edited> to make sure they're prettiered correctly.

auto-merge was automatically disabled March 18, 2024 21:22

Head branch was pushed to by a user without write access

@ariannargesi
Copy link
Contributor Author

@samcx Done

@samcx samcx enabled auto-merge (squash) March 18, 2024 21:26
@samcx samcx merged commit a2e3b27 into vercel:canary Mar 18, 2024
28 checks passed
@ariannargesi ariannargesi deleted the upgrade-example branch March 23, 2024 22:00
@github-actions github-actions bot added the locked label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariannargesi @ijjk @samcx