Prebuilt skew protection cleanup #88920
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+473
to
+477
| // Don't override NEXT_DEPLOYMENT_ID if it's already set by Vercel | ||
| // This prevents conflicts when Vercel manages deployment IDs internally | ||
| if (!process.env.NEXT_DEPLOYMENT_ID) { | ||
| process.env.NEXT_DEPLOYMENT_ID = id | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| // Don't override NEXT_DEPLOYMENT_ID if it's already set by Vercel | |
| // This prevents conflicts when Vercel manages deployment IDs internally | |
| if (!process.env.NEXT_DEPLOYMENT_ID) { | |
| process.env.NEXT_DEPLOYMENT_ID = id | |
| } | |
| // When runtimeServerDeploymentId is disabled, the config value is authoritative | |
| // and should override any pre-existing environment variable to ensure consistency | |
| // between this.deploymentId and process.env.NEXT_DEPLOYMENT_ID | |
| process.env.NEXT_DEPLOYMENT_ID = id |
When runtimeServerDeploymentId is disabled and process.env.NEXT_DEPLOYMENT_ID is pre-set, divergence between this.deploymentId and process.env.NEXT_DEPLOYMENT_ID causes client/server deployment ID mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up un-used error & also allow for both user configured & vercel set deployment ids.