Add direct-key SST format support for optimized integer-keyed families #88921
+2,271
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new storage format for families with fixed-size integer keys: - FamilyFormat trait for per-family storage configuration - Direct-key fixed-value format: inline storage without compression - Direct-key variable-value format: direct keys with compressed values - MetaEntryFlags extension for format metadata - New SST writers: write_direct_fixed_sst(), write_direct_variable_sst() - New SST readers: lookup_direct_fixed(), lookup_direct_variable() This enables ~40% size reduction for TaskIdToTaskTypeHash and ~8 bytes/entry savings for TaskMeta/TaskData families.
nextjs-bot
added
created-by: Turbopack team
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **432 kB** → **432 kB** ✅ -32 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Merging this PR will not alter performance
Comparing 
Footnotes
|
- Add MetaFileFormat enum (Hashed, DirectFixed, DirectVariable) to distinguish entry formats in meta files - Create format-specific entry structs: HashedMetaEntry, DirectFixedMetaEntry, DirectVariableMetaEntry with appropriate fields for each format type - Wrap entries in MetaEntry enum with type-safe accessors (as_hashed(), as_direct_fixed(), as_direct_variable()) - Update MetaFileBuilder to write format byte and format-specific entries - Update MetaFile::open_internal to read format byte and parse format-specific entries - Add unreachable!() assertions for impossible cases in db.rs (AMQF miss and blob values in direct-fixed format) - Update README with new meta file format documentation Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add comprehensive test coverage for the new direct-key formats: - test_direct_variable_sst: Tests write_direct_variable_sst and lookup_direct_variable covering all value types (small, medium, deleted, blob reference) - test_meta_file_direct_fixed_roundtrip: Tests meta file write/read for DirectFixed format entries with end-to-end lookup verification - test_meta_file_direct_variable_roundtrip: Tests meta file write/read for DirectVariable format entries with end-to-end lookup verification Also fixes a bug in lookup_direct_variable where the standard block offset calculations were used instead of the direct-variable layout. Added specialized methods for direct-variable block access: - decode_direct_variable_value - get_direct_variable_block_range - get_direct_variable_block - read_direct_variable_block Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.