Turbopack: allow variable hash len in SST files #88938
Open
+227
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid wasting storage for hashes
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| // Accumulate until the block is full | ||
| if current_block_size > 0 | ||
| && (current_block_size + entry.key_len() + KEY_BLOCK_ENTRY_META_OVERHEAD | ||
| && (current_block_size + key_len + KEY_BLOCK_ENTRY_META_OVERHEAD |
Contributor
There was a problem hiding this comment.
KEY_BLOCK_ENTRY_META_OVERHEAD constant does not account for variable hash_len (0-8 bytes), causing blocks to potentially exceed MAX_KEY_BLOCK_SIZE limit or be severely underutilized
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **432 kB** → **432 kB** ✅ -32 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
nextjs-bot
added
created-by: Turbopack team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change the SST format to allow a variable hash len.
For short keys avoid storing the hashes and recompute them on demand instead.
For short keys use bit rotation instead of a real hash.
This avoid wasting storage for hashes which can be cheaply recomputed