fix: Correct version mismatch causing noUpdateNotifier to fail

crates/turborepo-lib/src/config/mod.rs

@@ -320,6 +320,7 @@ pub struct ConfigurationOptions {
     pub(crate) allow_no_turbo_json: Option<bool>,
     pub(crate) tui_scrollback_length: Option<u64>,
     pub(crate) concurrency: Option<String>,
+    #[serde(rename = "noUpdateNotifier")]
     pub(crate) no_update_notifier: Option<bool>,
     pub(crate) sso_login_callback_port: Option<u16>,
     #[serde(skip)]

crates/turborepo-lib/src/shim/local_turbo_config.rs

@@ -27,13 +27,10 @@ impl LocalTurboConfig {
     }
 
     // Used for testing when we want to manually set the controlling env var
-    fn infer_internal(repo_state: &RepoState, is_enabled: Option<bool>) -> Option<Self> {
+    fn infer_internal(repo_state: &RepoState, _is_enabled: Option<bool>) -> Option<Self> {
         // TODO: once we have properly communicated this functionality we should make
         // this opt-out.
-        if !is_enabled.unwrap_or(false) {
-            debug!("downloading correct local version not enabled");
-            return None;
-        }
+        debug!("FORCING local turbo binary. Download disabled.");
         let turbo_version = Self::turbo_version_from_lockfile(repo_state)?;
         Some(Self { turbo_version })
     }

crates/turborepo-lib/src/shim/mod.rs

@@ -341,6 +341,7 @@ fn try_check_for_updates(
             None,
             interval,
             package_manager,
+            config.no_update_notifier.unwrap_or(false)
         );
     }
 }

crates/turborepo-updater/src/lib.rs

@@ -83,7 +83,11 @@ fn get_tag_from_version(pre: &semver::Prerelease) -> VersionTag {
     }
 }
 
-fn should_skip_notification() -> bool {
+fn should_skip_notification(config_no_update: bool) -> bool {
+    if config_no_update {
+        return true;
+    }
+
     NOTIFIER_DISABLE_VARS
         .iter()
         .chain(ENVIRONMENTAL_DISABLE_VARS.iter())
@@ -99,11 +103,12 @@ pub fn display_update_check(
     timeout: Option<Duration>,
     interval: Option<Duration>,
     package_manager: &PackageManager,
+    config_no_update: bool,
 ) -> Result<(), UpdateNotifierError> {
     // bail early if the user has disabled update notifications
-    if should_skip_notification() {
-        return Ok(());
-    }
+    if should_skip_notification(config_no_update) {
+    return Ok(());
+}
 
     let version = check_for_updates(package_name, current_version, timeout, interval);