fix: Add fine grained interruptible task restarts in watch mode #11135
+171
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@johnpyp is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
johnpyp
changed the title
johnpyp
changed the title
johnpyp
force-pushed
the
fix/interruptible-task-termination
branch
2 times, most recently
from
0475181 to
c091360
Compare
johnpyp
force-pushed
the
fix/interruptible-task-termination
branch
from
c091360 to
de049c1
Compare
johnpyp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9421
This PR refactors watch mode task restarts to be "fine-grained", such that if a package changes, only active tasks which rely on that output get killed and restarted.
(Similar to #10846, but taking a slightly different approach which I think is cleaner).
Testing Instructions
Manual testing confirms the issue is fixed with this change. There aren't any existing automated tests for
watchand the like, given that it's a long running process I assume.