-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(vt100) increase render performance for tui_term
codepath
#9123
Draft
chris-olszewski
wants to merge
3
commits into
main
Choose a base branch
from
olszewski/perf_vt100_minor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
olszewski/perf_vt100_minor
branch
from
September 10, 2024 11:50
305802d
to
fb76b25
Compare
tknickman
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The crate
tui_term
renders thevt100::Screen
by fetching each cell and then filling theratatui::buffer:Cell
with the vt100 cell's contents.This leads to the following functions being called once for each cell on the users terminal:
Cell::contents
which unnecessarily allocates on every call even though there's a fixed limit to the size of thestr
that could be returned. This PR changes this method to return a&str
that is constructed from the content bytes. The new helper functionappend_char
is basicallyString::push
Grid::visible_row
which iterates through the scrollback rows and screen rows. This PR changes this to instead index directly into the rowsTesting Instructions
Tested by profiling this basic script that render a tui_term 1000 times.
The two functions that this targets:
fill_buf_cell
codepathBefore
After
Aftervisible_cell
codepathBefore