Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages listed twice in watch mode #9644

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

maciej-ka
Copy link
Contributor

Description

Fixes: #9538

The WatchClient::new already lists packages as a part of start_ui.
Therefore, an additional prelude print in WatchClient::start appears redundant.

Testing Instructions

  1. setup a devturbo alias
  2. clone https://github.com/remotion-dev/remotion
  3. run devturbo watch make

@maciej-ka maciej-ka requested a review from a team as a code owner December 20, 2024 23:32
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm

Copy link

vercel bot commented Dec 20, 2024

@maciej-ka is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Dec 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 42846e4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@chris-olszewski
Copy link
Member

@maciej-ka This PR is great! Our CI requires me to approve a run for each additional commit so please do not merge main unless necessary.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dziękuję!

@maciej-ka
Copy link
Contributor Author

@chris-olszewski Również dziekuję! 🎉 🎉
If you would have a suggestion on a "good second issue" I'm all ears.

@chris-olszewski
Copy link
Member

chris-olszewski commented Dec 23, 2024

@maciej-ka

Something that's a little more advanced, but self contained is #8476.

The issue is that we don't remove and restore directories in the output. For the most case this doesn't matter, but if something created a symlink in the output it results in unexpected behavior upon a cache hit. I believe the fix will be adding some logic in this method.

I added a test that displays this behavior in #9646

If you have JS experience there are many issues related to our examples that could use a pair of eyes. This one is fixing some peer dependencies

@maciej-ka
Copy link
Contributor Author

maciej-ka commented Dec 23, 2024

Thanks for spending time, recommending these.
Both the cache and example problems looks like a great match 🥬🐇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whole package list is printed twice in watch mode
3 participants