-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: packages listed twice in watch mode #9644
fix: packages listed twice in watch mode #9644
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@maciej-ka is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
@maciej-ka This PR is great! Our CI requires me to approve a run for each additional commit so please do not merge main unless necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dziękuję!
@chris-olszewski Również dziekuję! 🎉 🎉 |
Something that's a little more advanced, but self contained is #8476. The issue is that we don't remove and restore directories in the output. For the most case this doesn't matter, but if something created a symlink in the output it results in unexpected behavior upon a cache hit. I believe the fix will be adding some logic in this method. I added a test that displays this behavior in #9646 If you have JS experience there are many issues related to our examples that could use a pair of eyes. This one is fixing some peer dependencies |
Thanks for spending time, recommending these. |
Description
Fixes: #9538
The
WatchClient::new
already lists packages as a part ofstart_ui
.Therefore, an additional prelude print in
WatchClient::start
appears redundant.Testing Instructions
devturbo watch make