Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear //TODO: refactor, state on value change listener is not required, compose will do the magic #50

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

clear //TODO: refactor, state on value change listener is not required, compose will do the magic #50

wants to merge 5 commits into from

Conversation

sulisyo
Copy link
Contributor

@sulisyo sulisyo commented Oct 13, 2022

Cut the unnecessary OnSomething listener.

@sulisyo sulisyo changed the title refactor optimize code clear //TODO: refactor, state on value change listener is not required, compose will do the magic Oct 13, 2022
@sulisyo sulisyo requested review from uziwuzzy, johndhabifj and jordeliu and removed request for uziwuzzy and johndhabifj October 13, 2022 08:55
@jordeliu
Copy link
Contributor

please resolve conflict pak

@jordeliu
Copy link
Contributor

have you retested this pak ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordeliu jordeliu jordeliu approved these changes

@uziwuzzy uziwuzzy Awaiting requested review from uziwuzzy

@johndhabifj johndhabifj Awaiting requested review from johndhabifj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sulisyo @jordeliu