Allows certain welders and solders to accept plasma and pacid respectively for faster work. #37669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do they explode bigger when i light a welding tank with them |
|
allow solders to take lead |
west3436
reviewed
Jun 9, 2025
Comment on lines
+446
to
+451
| if(type == FUEL) | ||
| return reagents.get_reagent_amount(FUEL) | ||
| else if(type == PLASMA) | ||
| return reagents.get_reagent_amount(PLASMA) | ||
| else | ||
| return reagents.get_reagent_amount(FUEL) + reagents.get_reagent_amount(PLASMA) |
There was a problem hiding this comment.
Suggested change
| if(type == FUEL) | |
| return reagents.get_reagent_amount(FUEL) | |
| else if(type == PLASMA) | |
| return reagents.get_reagent_amount(PLASMA) | |
| else | |
| return reagents.get_reagent_amount(FUEL) + reagents.get_reagent_amount(PLASMA) | |
| return reagents.get_reagent_amount(FUEL) + reagents.get_reagent_amount(PLASMA) |
keep it simple
Comment on lines
+956
to
+961
| if(type == SACID) | ||
| return reagents.get_reagent_amounts(SACIDS) | ||
| else if(type == PACID) | ||
| return reagents.get_reagent_amounts(PACIDS) | ||
| else | ||
| return reagents.get_reagent_amounts(SACIDS + PACIDS) |
There was a problem hiding this comment.
Suggested change
| if(type == SACID) | |
| return reagents.get_reagent_amounts(SACIDS) | |
| else if(type == PACID) | |
| return reagents.get_reagent_amounts(PACIDS) | |
| else | |
| return reagents.get_reagent_amounts(SACIDS + PACIDS) | |
| return reagents.get_reagent_amounts(SACIDS + PACIDS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[content]
What this does
Allows gatling welders to accept plasma for faster welding and screwsolders to accept pacid for faster soldering. (could probably make regular solders accept pacid too because of how rare screwsolders are, lemme know. ditto other more advanced welders)
Rewrites a few soldering do_afters into a do_solder function to put it on parity with welders and make coding this whole thing easier.
Why it's good
Gives these chems more helpful uses around the station.
How it was tested
Blank circuitboards, suit storage units, lockers, account databases and media broadcasters can all still be soldered.
Pacid affects solder speed.
Plasma affects welding speed.
Changelog
🆑