Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg index --snarl-limithas a threshold equal to a snarl's size, it no longer counts as an automatic snarl--snarl-limittoDescription
Take two! While previously I'd fixed the temporary distance index so that it now performs pairwise distance calculations when N=
size_limit, those calculations were all wasted because the same off-by-one error existed when transferring distance values over from the temporary index to the final index. Poked my head into libbdsg to fix that: vgteam/libbdsg#228Also, I added that max snarl size hint I mentioned in the previous PR, since I had to play with libbdsg anyhow.
@adamnovak help I don't know how to get the submodule update to play nice :( I think I did it wrong.