-
Notifications
You must be signed in to change notification settings - Fork 156
Add Windows llvm debug build #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
vgvassilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the bots are not picking up these changes, right?
|
@vgvassilev They only build llvm on Windows if debug=true in the ci. If you look at the first commit where I forgot to add this condition, the ci is building llvm on Windows before I stopped the job. |
Can we make a new configuration that builds llvm on windows, caches it and builds clad against it? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@vgvassilev This PR is ready for review. If you look at the ci it uses the built cache to build Clad. If you merge, remember to clear the cache before you merge. I'll put in a PR at some point to reduce the size of the cache. |
I think we will need a bit more to this. We need to compile with Then we need to compile clad with: |
|
@vgvassilev I'll do this once you clear the cache for this PR. I'll also try and reduce the size of the cache at the same time. |
Done! |
|
@vgvassilev I've made the changes you requested (using clang-cl to build llvm, and use certain options when building clad), but it fails with a linker error when building llvm. Any suggestions of a fix? |
377f680 to
20a7117
Compare
262192c to
824095f
Compare
|
Are there any news on this? |
|
Now that the llvm this PR is building is llvm 20 (temporarily a fork of the llvm-project until the changes are upstream) this PR shall wait for #1267 to go in. |
This PR should allow Clad to be tested against the head of release branch of llvm on Windows.