Skip to content

Conversation

@mcbarton
Copy link
Contributor

This PR should allow Clad to be tested against the head of release branch of llvm on Windows.

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bots are not picking up these changes, right?

@mcbarton
Copy link
Contributor Author

@vgvassilev They only build llvm on Windows if debug=true in the ci. If you look at the first commit where I forgot to add this condition, the ci is building llvm on Windows before I stopped the job.

@vgvassilev
Copy link
Owner

@vgvassilev They only build llvm on Windows if debug=true in the ci. If you look at the first commit where I forgot to add this condition, the ci is building llvm on Windows before I stopped the job.

Can we make a new configuration that builds llvm on windows, caches it and builds clad against it?

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mcbarton mcbarton requested a review from vgvassilev November 27, 2024 23:07
@mcbarton
Copy link
Contributor Author

@vgvassilev This PR is ready for review. If you look at the ci it uses the built cache to build Clad. If you merge, remember to clear the cache before you merge. I'll put in a PR at some point to reduce the size of the cache.

@vgvassilev
Copy link
Owner

@vgvassilev This PR is ready for review. If you look at the ci it uses the built cache to build Clad. If you merge, remember to clear the cache before you merge. I'll put in a PR at some point to reduce the size of the cache.

I think we will need a bit more to this. We need to compile with clang-cl to be able to pick up the windows exports. We should use something like cmake -GNinja -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_TARGETS_TO_BUILD=host -DLLVM_ENABLE_PLUGINS=On ..\llvm

Then we need to compile clad with: cmake -DCMAKE_BUILD_TYPE=Debug -DLLVM_DIR=c:\vv-llvm-dev\llvm-project\build -GNinja -DLLVM_BUILD_LLVM_DYLIB_VIS=On -DLLVM_LINK_LLVM_DYLIB=On -DCLANG_LINK_CLANG_DYLIB=On ..\clad

@mcbarton
Copy link
Contributor Author

@vgvassilev I'll do this once you clear the cache for this PR. I'll also try and reduce the size of the cache at the same time.

@vgvassilev
Copy link
Owner

@vgvassilev I'll do this once you clear the cache for this PR. I'll also try and reduce the size of the cache at the same time.

Done!

@mcbarton
Copy link
Contributor Author

mcbarton commented Dec 9, 2024

@vgvassilev I've made the changes you requested (using clang-cl to build llvm, and use certain options when building clad), but it fails with a linker error when building llvm. Any suggestions of a fix?

@mcbarton mcbarton force-pushed the Windows-llvm-build-ci branch from 377f680 to 20a7117 Compare December 16, 2024 11:29
@mcbarton mcbarton force-pushed the Windows-llvm-build-ci branch from 262192c to 824095f Compare December 17, 2024 17:35
@vgvassilev
Copy link
Owner

Are there any news on this?

@mcbarton
Copy link
Contributor Author

mcbarton commented Apr 3, 2025

Now that the llvm this PR is building is llvm 20 (temporarily a fork of the llvm-project until the changes are upstream) this PR shall wait for #1267 to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants