[RSDK-10114] - Add non-breaking point_cloud_enabled attribute
#62
+33
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
changed the title
point_cloud_enabled attribute
hexbabe
changed the title
point_cloud_enabled attributepoint_cloud_enabled attribute
hexbabe
commented
Feb 27, 2025
|
|
||
| # Use the worker manager to properly restart the worker | ||
| # This avoids race conditions with the worker's pipeline | ||
| self.worker_manager.restart_atomic_bool.set(True) |
There was a problem hiding this comment.
Is this thing actually doing anything in the pointcloud worker? or is it just polling whether the oak-d had a pointcloud invoked?
There was a problem hiding this comment.
Seems like the latter - removing this is a good design choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is better design to add an attribute to configure the pipeline for PCD rather than dynamically reconfiguring when a user calls
get_point_cloudto do so.