-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vietnamese calendar #490
base: master
Are you sure you want to change the base?
Conversation
f4f4683
to
f2a8611
Compare
92a3609
to
839811e
Compare
Thanks @trmdi ! I wanted to do something similar when I came across the Iranian calendar while translating to Farsi, but it was a lot of work 😅 Your implementation seems pretty clean so thank you for that! I'll look into adding more calendars, and adding a toggle option. Can't tell when though. Do you think this calendar should be enabled by default for Vietnamese users ? |
839811e
to
6ab5fca
Compare
Yes, I think so. Since printed calendars have it, and Samsung phones also enable it by default. |
Interesting, enabled by default it is 👍 |
6ab5fca
to
c12ef57
Compare
c12ef57
to
1bd0d2f
Compare
So this could be merged for the next release or you have other requirements? (besides adding more calendars, which should be done later, one by one) |
It will be in the next small update: 20.3.0 ! |
Bonjour!
I want to add Vietnamese secondary calendar (Lunar Calendar).
It's only visible when the language is Vietnamese.
When there are multiple clocks, it's only visible on clocks with
Asia/Ho_Chi_Minh
timezone.Look forward to your thoughts!