Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese calendar #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trmdi
Copy link

@trmdi trmdi commented Nov 6, 2024

Bonjour!

I want to add Vietnamese secondary calendar (Lunar Calendar).
It's only visible when the language is Vietnamese.
When there are multiple clocks, it's only visible on clocks with Asia/Ho_Chi_Minh timezone.

Look forward to your thoughts!

image
image

@trmdi trmdi force-pushed the add-vietnamese-calendar branch 2 times, most recently from f4f4683 to f2a8611 Compare November 7, 2024 03:39
@trmdi trmdi marked this pull request as ready for review November 7, 2024 03:41
@trmdi trmdi force-pushed the add-vietnamese-calendar branch 3 times, most recently from 92a3609 to 839811e Compare November 8, 2024 05:10
@victrme
Copy link
Owner

victrme commented Nov 8, 2024

Thanks @trmdi !

I wanted to do something similar when I came across the Iranian calendar while translating to Farsi, but it was a lot of work 😅

Your implementation seems pretty clean so thank you for that! I'll look into adding more calendars, and adding a toggle option. Can't tell when though.

Do you think this calendar should be enabled by default for Vietnamese users ?

@trmdi
Copy link
Author

trmdi commented Nov 8, 2024

Do you think this calendar should be enabled by default for Vietnamese users ?

Yes, I think so. Since printed calendars have it, and Samsung phones also enable it by default.

@victrme
Copy link
Owner

victrme commented Nov 8, 2024

Interesting, enabled by default it is 👍

@trmdi
Copy link
Author

trmdi commented Nov 12, 2024

So this could be merged for the next release or you have other requirements? (besides adding more calendars, which should be done later, one by one)
I really like this extension and want to introduce it to my friends. I hope it will be available in the next release.

@victrme victrme added this to the Version 20.3 milestone Nov 13, 2024
@victrme
Copy link
Owner

victrme commented Nov 13, 2024

It will be in the next small update: 20.3.0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

Successfully merging this pull request may close these issues.

2 participants