Skip to content

Switch level on "internal-error" key status #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 18, 2025

This PR will...

Switch level on "internal-error" key status.

Why is this Pull Request needed?

Requested by @yajin2021 in #7401 and #7413.

Are there any points in the code the reviewer needs to double check?

Should recovery be attempted if an "internal-error" key status is received, or will all keys (including current "usable" keys) error in tow?

According to the spec, no. We probably should not do this:
https://www.w3.org/TR/encrypted-media-2/#dom-mediakeysessionclosedreason-internal-error

internal-error | The session was closed because of an unrecoverable error in the CDM. When this occurs, applications MUST NOT create new sessions on this MediaKeys instance.

Resolves issues:

#7413

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.7.0 milestone Jul 18, 2025
@robwalch robwalch added the DRM label Jul 18, 2025
@robwalch robwalch marked this pull request as draft July 18, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant