Conversation
5 tasks
5 tasks
Fixes #7413 (playback/switching fails on KEY_SYSTEM_STATUS_INTERNAL_ERROR 'internal-error' key status)
3c00a0f to
30c6ca4
Compare
2709b7a to
5d86f38
Compare
Add "FIXME" comments for future MediaKeySessionContext multi-key handling improvements
Collaborator
Author
|
Commented on flaws in hls.js/src/controller/eme-controller.ts Lines 55 to 60 in 7a089f0 |
…Y_LOADING // reproducable with `hls.once(Hls.Events.KEY_LOADING, () => hls.removeLevel(hls.loadLevel))`
5 tasks
bf0c2b0 to
a2c0369
Compare
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
@yajin2021 reported that other variants should be selected when a key error occurs:
Preventing appends of media with bad keys prevents the CDM from locking up playback. I was not able to append the media optimistically, and then remove it from the buffer on key error before a switch. Either hls.js queued too much media (appending more after the first key error) or any appends that cannot be decrypted interfere with playback.
Are there any points in the code the reviewer needs to double check?
Created #7474 for #7414 (comment) to be addressed in a future release.
Resolves issues:
Checklist