Skip to content

Conversation

@christriants
Copy link
Contributor

@christriants christriants commented Sep 20, 2025

This PR will...

  • Upgrade the sinon dependency to v21.0.0
  • Import nise for fakeXhr and fakeServer to replace usage of removed fakeXMLHttpRequest and fakeServer sinon functions (removed in v20.0.0).

Resolves issues:

Resolves #7157

Checklist

  • changes have been done against master branch, and PR does not conflict
  • all unit / functional tests should run successfully
  • API or design changes are documented in API.md

@christriants christriants marked this pull request as ready for review September 20, 2025 12:07
Copy link
Member

@tjenkinson tjenkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@robwalch robwalch added this to the 1.7.0 milestone Sep 20, 2025
@robwalch robwalch merged commit ec14649 into video-dev:master Sep 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Migrate dependency sinon to v20

3 participants