Fix endless while loop in gap controller with bad streams #7661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration 0) Adjust initPTS when segments have the same start time #7656
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix endless while loop in gap controller with bad streams where segment duration is calculated as 0
Adjust initPTS when segments have the same start time
Why is this Pull Request needed?
JS should not lock up the page when there are unmarked discontinuities and out of sync audio and video segments that result in buffer gaps or otherwise unplayable timelines.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist