Update Readme #44
Merged
Update Readme #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
englishm
reviewed
Jan 29, 2025
englishm
reviewed
Jan 29, 2025
englishm
approved these changes
Jan 29, 2025
Member
englishm
left a comment
englishm
left a comment
There was a problem hiding this comment.
Thank you so much for updating these docs!
Only minor phrasing nits. I think we can update the exact package URL after the fact once we get the publishing PR merged with those exact details pinned down.
englishm
reviewed
Jan 29, 2025
| Or include via a `<script>` tag (for the IIFE build): | ||
|
|
||
| ```html | ||
| <script src="https://cdn.jsdelivr.net/npm/package@latest/dist/moq-player.iife.js"></script> |
Member
There was a problem hiding this comment.
We should merge this PR first and then update this line to the real URL in #43 along with the package.json updates so we know they're in sync.
Contributor
Author
There was a problem hiding this comment.
Yes, that's why I didn't include the package name and version.
Co-authored-by: Mike English <[email protected]>
Co-authored-by: Mike English <[email protected]>
englishm
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.