Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lang): update zh-TW translations #8929

Merged

Conversation

SimonAllen0901
Copy link
Contributor

@SimonAllen0901 SimonAllen0901 commented Nov 26, 2024

Description

  • Add "Playing in Picture-in-Picture" translations to zh-TW.json
  • Deduplicate object keys in zh-TW.json
  • Update translations-needed.md
    • Auto-generated - The np.json section removed from translations-needed.md was a duplicate.

Specific Changes proposed

  • Add missing translation for "Playing in Picture-in-Picture" to zh-TW locale.
  • Remove duplicate keys 'Picture-in-Picture' and 'Exit Picture-in-Picture' from zh-TW.json to eliminate redundancy.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Docs/guides updated
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

- add missing translations to zh-TW.json
- deduplicate object keys in zh-TW.json
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (ca6f823) to head (923bfc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8929   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         120      120           
  Lines        8110     8110           
  Branches     1949     1949           
=======================================
  Hits         6790     6790           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harisha-swaminathan harisha-swaminathan merged commit b6cec4f into videojs:main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants