Skip to content

fix: invalid HTML #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: invalid HTML #9040

wants to merge 1 commit into from

Conversation

ahosgood
Copy link

@ahosgood ahosgood commented May 9, 2025

Description

Fixes HTML validation

Specific Changes proposed

Added a role of "group" to all MenuButton components removes the HTML validation issue of:

An element with role=menuitemradio must be contained in, or owned by, an element with role=menubar or role=menu or role=group

...as MenuItem components can have a role.

Tested in https://validator.w3.org/ with the included sandbox example.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Added a role of "group" to all MenuButton components removes the HTML validation issue of "An element with role=menuitemradio must be contained in, or owned by, an element with role=menubar or role=menu or role=group" as MenuItem components can have a role.
Copy link

welcome bot commented May 9, 2025

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@ahosgood ahosgood changed the title fix: add role="group" to MenuButton for valid HTML fix: invalid HTML May 9, 2025
Copy link

@opa26033 opa26033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Op bro,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants