[#148] Dialog block #162
Open
[#148] Dialog block #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+35
to
+36
| "viewStyle": "file:./view.css", | ||
| "editorStyle": "file:./editor.css", |
There was a problem hiding this comment.
This is really nice to have style for both!!
There was a problem hiding this comment.
All the alpine.js is from blueprint.
There was a problem hiding this comment.
Cursor did all the heavy lifting of moving its from PHP to Twig. 🎉
There was a problem hiding this comment.
Not sure if we could add a ACF field or if there is another way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the Dialog block to the site starter. It has a very basic style, one the WP page editor it opens inline and on the frontend it opens as a dialog window.
The block is a wrapper so any block (custom or core) will render inside of the dialog.
@bd-viget added a ACF field for the open button text, not sure if there is a better way to build it.
Issues
Testing Instructions
Screenshots