Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify time measuring units in all implementations #3

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

vikman90
Copy link
Owner

@vikman90 vikman90 commented Feb 23, 2024

After researching #2, we discovered that the following implementations were reporting the time in milliseconds:

  • JavaScript
  • Java
  • C#
  • Python
  • PHP

This was causing an unfair advantage to these languages in the comparison.

Fix proposed

Every implementation must report the execution time in milliseconds at the testing output.

@vikman90 vikman90 added the bug Something isn't working label Feb 23, 2024
@vikman90 vikman90 self-assigned this Feb 23, 2024
@vikman90 vikman90 linked an issue Feb 23, 2024 that may be closed by this pull request
@vikman90
Copy link
Owner Author

Implementation Steps/ms (max) Steps/ms (avg) Discards/ms (max) Discards/ms (avg)
C++ 496,40 125,20 30.023,02 10.715,92
Rust 355,49 93,10 24.365,76 5.793,85
Go 310,16 72,91 17.422,22 1.282,14
JavaScript 124,19 29,49 3.361,07 1.629,27
C# 46,36 22,65 4.853,36 1.263,75
Java 21,21 13,26 4.176,81 1.047,12
Python 13,39 2,17 704,93 519,03

@vikman90 vikman90 merged commit 90bbcc4 into master Feb 23, 2024
13 checks passed
@vikman90 vikman90 deleted the fix-timing branch February 23, 2024 20:31
@vikman90 vikman90 restored the fix-timing branch February 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong time measure in some implementations
1 participant