Merged
Conversation
Implement a Mangler implementation that takes two type-arguments that are directly convertible to convert to and from. This will facilitate point-substituting time.Duration with a type that's also an int64, but has an `UnmarshalJSON` method that calls `time.ParseDuration` if it's passed a JSON string, and parses an integer as nanoseconds if passed a JSON integer/number. -- for use by the json and cue decoders.
sergiosalvatore
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a Mangler implementation that takes two type-arguments that are directly convertible to convert to and from.
This will facilitate point-substituting time.Duration with a type that's also an int64, but has an
UnmarshalJSONmethod that callstime.ParseDurationif it's passed a JSON string, and parses an integer as nanoseconds if passed a JSON integer/number. -- for use by the json and cue decoders.