Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Error from pflag #96

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sergiosalvatore
Copy link
Contributor

@sergiosalvatore sergiosalvatore commented Aug 30, 2024

Pflag has types for all the integer sizes so we don't need to check for overflowing and thus this code that was inherited from the flag package is unnecessary.

This fixes:

sources/pflag.go L495: impossible condition: nil != nil

Pflag has types for all the integer sizes so we don't need to check for
overflowing and thus this code that was inherited from the flag package
is unnecessary.
@sergiosalvatore sergiosalvatore merged commit 5d23ad9 into master Aug 30, 2024
8 checks passed
@sergiosalvatore sergiosalvatore deleted the pflag-remove-unnecessary branch August 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants