Use more relax php version range #11517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge 👍 |
|
Please yes 🙏 |
|
The version range was chosen due to critical bugs in older PHP versions that directly affect psalm. |
|
psalm is mostly used as dev dependency, imo, it doesn't need to be in latest php, as CI is also green |
I think so, It would be nice if it were considered |
|
You don't understand, the php bugs affect directly Psalm, causing crashes and false positives or negatives during scans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on some system, eg: macos using macports, the php version latest may not up to date, I think it is better to have more relax version to avoid error: