issue #609

Author: vincentarelbundock

DESCRIPTION

@@ -2,7 +2,7 @@ Package: tinytable
 Type: Package
 Title: Simple and Configurable Tables in 'HTML', 'LaTeX', 'Markdown', 'Word', 'PNG', 'PDF', and 'Typst' Formats
 Description: Create highly customized tables with this simple and dependency-free package. Data frames can be converted to 'HTML', 'LaTeX', 'Markdown', 'Word', 'PNG', 'PDF', or 'Typst' tables. The user interface is minimalist and easy to learn. The syntax is concise. 'HTML' tables can be customized using the flexible 'Bootstrap' framework, and 'LaTeX' code with the 'tabularray' package.
-Version: 0.15.0.2
+Version: 0.15.0.3
 Imports:
     methods
 Depends:
@@ -44,5 +44,5 @@ Authors@R: c(
   comment = c(ORCID = "0000-0003-2042-7063")))
 License: GPL (>= 3)
 Encoding: UTF-8
-RoxygenNote: 7.3.2
+RoxygenNote: 7.3.3
 Roxygen: list(markdown = TRUE)

NEWS.md

@@ -1,5 +1,11 @@
 # News
 
+## 0.15.0.2
+
+Bugs:
+
+* `style_tt()` with a logical matrix containing all `FALSE` values no longer throws an error (Issue #609, thanks to @EinMaulwurf).
+
 ## 0.15.0.1
 
 Misc:

R/style_tt.R

@@ -322,17 +322,22 @@ style_tt_lazy <- function(
   if (!is.matrix(i) || !is.logical(i)) {
     settings <- process_align_argument(x, settings, align)
   } else {
-    settings$align <- NA_character_
+    if (nrow(settings) > 0) {
+      settings$align <- NA_character_
+    }
   }
 
   # sort column: important for bind
   cols <- unique(c("i", "j", sort(colnames(settings))))
   settings <- settings[, cols, drop = FALSE]
 
-  if (nrow(out@style) == 0) {
-    out@style <- settings
-  } else {
-    out@style <- rbind(out@style, settings)
+  # Only add settings if there are rows to add
+  if (nrow(settings) > 0) {
+    if (nrow(out@style) == 0) {
+      out@style <- settings
+    } else {
+      out@style <- rbind(out@style, settings)
+    }
   }
 
   if (is.function(finalize)) {

README.md

@@ -1,6 +1,7 @@
 
 
 <p align="center">
+
 <img src="man/figures/gallery/tinytable_gallery.gif" height = "250" class = "center">
 <br> <!-- badges: start -->
 <a href = "https://github.com/vincentarelbundock/tinytable/blob/main/LICENSE.md" target = "_blank"><img src="https://img.shields.io/badge/license-GPLv3-blue"></a>
@@ -12,14 +13,14 @@
 ## What?
 
 `tinytable` is a small but powerful `R` package to draw beautiful tables
-in a variety of formats: HTML, LaTeX, Word[1], PDF, PNG, Markdown, and
+in a variety of formats: HTML, LaTeX, Word[^1], PDF, PNG, Markdown, and
 Typst. The user interface is minimalist and easy to learn, while giving
 users access to powerful frameworks to create endlessly customizable
 tables.
 
 <https://vincentarelbundock.github.io/tinytable/>
 
-> **Note**
+> [!NOTE]
 >
 > The documentation on this website uses the latest development version
 > of `tinytable`. This version can normally be installed from
@@ -49,25 +50,24 @@ ecosystem. Why release a new one? As [the maintainer of
 `modelsummary`](https://modelsummary.com), I needed a table-drawing
 package which was:
 
--   *Simple*: Streamlined, consistent, and uncluttered user interface,
-    with few functions to learn.
--   *Flexible*: Expressive frameworks to customize tables in HTML and
-    LaTeX formats.[2]
--   *Zero-dependency*: Avoid importing any other `R` package.[3]
--   *Concise*: Draw beautiful tables without typing a lot of code.
--   *Safe*: User inputs are checked thoroughly, and informative errors
-    are returned early.
--   *Maintainable*: A small code base which does not rely on too many
-    complex regular expressions.
--   *Readable*: HTML and LaTeX code should be human-readable and
-    editable.
--   *Free*: This package will always be free. Tiny tables for a tiny
-    price!
+- *Simple*: Streamlined, consistent, and uncluttered user interface,
+  with few functions to learn.
+- *Flexible*: Expressive frameworks to customize tables in HTML and
+  LaTeX formats.[^2]
+- *Zero-dependency*: Avoid importing any other `R` package.[^3]
+- *Concise*: Draw beautiful tables without typing a lot of code.
+- *Safe*: User inputs are checked thoroughly, and informative errors are
+  returned early.
+- *Maintainable*: A small code base which does not rely on too many
+  complex regular expressions.
+- *Readable*: HTML and LaTeX code should be human-readable and editable.
+- *Free*: This package will always be free. Tiny tables for a tiny
+  price!
 
 To achieve these goals, the design philosophy of `tinytable` rests on
 three pillars:
 
-1.  *Data is separate from style.* The code that this package creates
+1)  *Data is separate from style.* The code that this package creates
     keeps the content of a table separate from the style sheet that
     applies to its cells. This is in contrast to other `R` packages that
     modify the actual text in each cell to style it. Keeping data and
@@ -76,13 +76,13 @@ three pillars:
     developers to keep a simpler code base, with minimal use of messy
     regular expressions.
 
-2.  *Flexibility.* Users’ needs are extremely varied, and a
+2)  *Flexibility.* Users’ needs are extremely varied, and a
     table-drawing package must be flexible enough to accomodate
     different ideas. To achieve this, `tinytable` builds on
     battle-tested and versatile frameworks like `Bootstrap` for HTML and
     `tabularray` for LaTeX.
 
-3.  Lightweight. Some of the most popular table-drawing packages in the
+3)  Lightweight. Some of the most popular table-drawing packages in the
     `R` ecosystem are very heavy: A single `library()` call can
     sometimes load upwards of 65 `R` packages. In contrast, `tinytable`
     imports zero 3rd party `R` package by default.
@@ -135,17 +135,17 @@ tt(x,
 
 ## Tutorial
 
-The `tinytable` 0.15.0 tutorial will take you much further. It is
+The `tinytable` 0.14.0 tutorial will take you much further. It is
 available in HTML and PDF formats at:
 <https://vincentarelbundock.github.io/tinytable/>
 
-[1] Styling options in Word are somewhat limited. See the FAQ page and
-the `style_tt()` documentation for details.
+[^1]: Styling options in Word are somewhat limited. See the FAQ page and
+    the `style_tt()` documentation for details.
 
-[2] Other formats like Markdown and Typst are also available, but less
-flexible.
+[^2]: Other formats like Markdown and Typst are also available, but less
+    flexible.
 
-[3] Some extra packages can be imported to access specific
-functionality, such as integration with Quarto, inserting `ggplot2`
-objects as inline plots, and saving tables to PNG images or PDF
-documents.
+[^3]: Some extra packages can be imported to access specific
+    functionality, such as integration with Quarto, inserting `ggplot2`
+    objects as inline plots, and saving tables to PNG images or PDF
+    documents.

inst/tinytest/test-style.R

@@ -96,3 +96,18 @@ expect_snapshot_print(t[["html"]], "style-align_partial.html")
 expect_snapshot_print(t[["latex"]], "style-align_partial.tex")
 expect_snapshot_print(t[["typst"]], "style-align_partial.typ")
 expect_snapshot_print(t[["markdown"]], "style-align_partial.md")
+
+
+# logical matrix with all FALSE values should not error
+testdata <- data.frame(
+  names = c('a', 'b', 'c', 'd', 'e'),
+  values1 = c(1, 2, 3, 4, 5),
+  values2 = c(6, 7, 8, 9, 10)
+)
+testdata_override <- matrix(FALSE, nrow = nrow(testdata), ncol = ncol(testdata))
+result <- testdata |>
+  tt() |>
+  style_tt(i = testdata_override, background = "red") |>
+  save_tt("html")
+expect_true(is.character(result))
+expect_true(nchar(result) > 0)