-
-
Notifications
You must be signed in to change notification settings - Fork 32
🔒 Security: Fix Jinja2 and py library vulnerabilities #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update Jinja2 from 3.1.5 to 3.1.6 to address ReDoS vulnerability - Remove py library (1.11.0) which has ReDoS vulnerability with no patch available - Regenerate requirements.txt files after dependency updates - Verify all 153 tests still pass after removing py library Fixes security vulnerabilities: - Jinja2 <= 3.1.5 (CVE-2024-22195) - py <= 1.11.0 (ReDoS in InfoSvnCommand)
Reviewer's GuideAddresses ReDoS vulnerabilities by upgrading Jinja2, removing the unneeded py package, and regenerating all requirement lock files. Class diagram for dependency management after security fixesclassDiagram
class DependencyManager {
+update_dependency(name, version)
+remove_dependency(name)
+regenerate_lock_files()
}
class Jinja2 {
-version: string
}
class Py {
-version: string
}
DependencyManager --> Jinja2 : manages
DependencyManager --> Py : manages
Jinja2 : version = "3.1.6"
Py : removed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vinitkumar - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 3 3
Lines 288 288
=======================================
Hits 286 286
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Security Fixes
This PR addresses two security vulnerabilities identified in the project dependencies:
🔐 Issues Fixed
Jinja2 <= 3.1.5 - ReDoS vulnerability (CVE-2024-22195)
py <= 1.11.0 - ReDoS vulnerability in InfoSvnCommand
✅ Testing
📋 Changes Made
🔍 Security Impact
Both vulnerabilities have been resolved:
This PR resolves the security alerts identified by GitHub's Dependabot scanner.
Summary by Sourcery
Fix two ReDoS vulnerabilities by upgrading Jinja2 to 3.1.6, removing the unneeded py library, and regenerating requirement files with all tests passing
Bug Fixes:
Enhancements:
Documentation: