Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix structure.sql end newline check #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix structure.sql end newline check #21

wants to merge 2 commits into from

Conversation

rkukutis
Copy link

@rkukutis rkukutis commented Nov 12, 2024 •
edited
Loading

Should check if there are exactly two newlines at the end of the structure.sql file. Two lines at the end are standard.

@vinted/rududu

maarsvin
maarsvin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@maarsvin maarsvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bump lib/pronto/rails_migrations/version.rb and rerun bundle install, you will get a change in gemfile

@rkukutis rkukutis force-pushed the fix/require-two-empty-lines-structure branch from 9ba2622 to d0db693 Compare November 12, 2024 13:38
@rkukutis rkukutis requested review from a team November 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarsvin maarsvin maarsvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkukutis @maarsvin